Cape Town | 26-ITP | Quentin Gwele | Sprint 2 | Coursework-2 - #1539
Open
lwandogwele52-ui wants to merge 5 commits into
Open
lwandogwele52-ui wants to merge 5 commits into
lwandogwele52-ui wants to merge 5 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lwandogwele52-ui
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
lwandogwele52-ui
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
lwandogwele52-ui
changed the title
This comment has been minimized.
This comment has been minimized.
lwandogwele52-ui
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
lwandogwele52-ui
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
lwandogwele52-ui
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
lwandogwele52-ui
added
the
Needs Review
hackertainment
added
Review in progress
|
Excellent piece of coursework with detail enough answers to cover key points, that describe and explain the concept accurately. Well done. Keep it up. p.s.: please fix the cohort to include month (e.g. 26-ITP-Sep) in the title of your PR. thank you. |
hackertainment
added
Complete
Comment on lines
+10
to
+15
| //Breakdown of the expression: | ||
| // 1. Math.random() generates a decimal number from 0 (inclusive) up to, but not including, 1. | ||
| // 2. (maximum - minimum + 1) calculates the range size (100 - 1 + 1 = 100). | ||
| // 3. Math.random() * 100 scales the random decimal to a range between 0 and 99.999... | ||
| // 4. Math.floor() rounds that value down to the nearest whole integer (0 to 99). | ||
| // 5. + minimum (+ 1) shifts the final value up into the target range of 1 to 100. |
There was a problem hiding this comment.
Good, comperhensive and clear enough.
lwandogwele52-ui
force-pushed
the
feature/sprint-2-exercises
branch
from
September 25, 2026 17:10
0f1d3d0 to
a6050ec
Compare
Hi @lwandogwele52-ui , from the GitHub log above, it seems like you were force pushing Sprint 3 coursework into this PR. However, Sprint 3 should have its own separate PR and please keep this PR for only Sprint 2. In case you are not sure how to do it, please ask a volunteer in the Saturday workshop. Thank you very much. |
hackertainment
added
the
Reviewed
Author
|
I have already separated the work.
…On Sat, 26 Sept 2026, 16:28 hackertainment, ***@***.***> wrote:
*hackertainment* left a comment
(CodeYourFuture/Module-JavaScript-Fundamentals#1539)
<#1539 (comment)>
***@***.*** <https://github.com/lwandogwele52-ui>* force-pushed
<https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/compare/0f1d3d051d915015f93ffdbe0c36abfe0ee0be63..a6050ecdbc1ca765d7c0084ea36fa86351db2a19>
the feature/sprint-2-exercises branch from 0f1d3d0
<0f1d3d0>
to a6050ec
<a6050ec>
yesterday
<#1539 (comment)>
Compare
<https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/compare/0f1d3d051d915015f93ffdbe0c36abfe0ee0be63..a6050ecdbc1ca765d7c0084ea36fa86351db2a19>
Hi @lwandogwele52-ui <https://github.com/lwandogwele52-ui> , from the
GitHub log above, it seems like you were force pushing Sprint 3 coursework
into this PR. Please keep this PR just for Sprint 2 and create a separate
PR for Sprint 3. In case you are not sure how to do it, please ask a
volunteer in the Saturday workshop. Thank you very much.
—
Reply to this email directly, view it on GitHub
<#1539?email_source=notifications&email_token=CFBVDQQAV62CWQJ7XYNHGYL5Q7HANA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOBUG4YDKNJVG4Y2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5847055571>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CFBVDQXINCIVK5PFLZBYH5L5Q7HANAVCNFSNUABFKJSXA33TNF2G64TZHM4DSOJQGI2DGMRUHNEXG43VMU5TKNJQGQYDAMBXHA32C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/CFBVDQRRVDMLSV57ARZFKQD5Q7HANA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOBUG4YDKNJVG4Y2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/CFBVDQXUDXBU2C5SE4IEDXL5Q7HANA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOBUG4YDKNJVG4Y2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
<CodeYourFuture/Module-JavaScript-Fundamentals/pull/1539/c5847055571@
github.com>
|
hackertainment
removed
the
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1039
Changelist
complete course work