Manchester | 26-ITP-Sep | Aklilu Mihtsun | Sprint 1 | Form Controls - #1499
Open
AkliluMihtsun wants to merge 7 commits into
Open
AkliluMihtsun wants to merge 7 commits into
AkliluMihtsun wants to merge 7 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AkliluMihtsun
added
the
Needs Review
tiakavousi
added
Review in progress
|
Nice work! You've made a solid start: semantic structure with header/main/footer, proper fieldset/legend grouping, and every label is correctly tied to its input with for/id. But there is a mix of must-fix issues and polish suggestions. Please add the Needs Review label again once you've pushed. |
tiakavousi
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist
-Used semantic HTML elements to improve the structure and accessibility of the page
and multiple sections-Added a structured customer/product form using
-Added elements to describe each fieldset
-Added required validation to fields that must be completed
-Added a pattern to ensure the customer's name contains at least two non-space characters
-Added styling for the page layout and form
-Checked the page with Lighthouse and achieved an Accessibility score of 100
Questions
-The "for" attribute in labels does it point to the id or name of the input?
-Why does the required attribute does not have value? Can we put value?