London | 26-ITP-Sep | Mars Adesina | Sprint 1 | Form Controls - #1498
Open
marscancode wants to merge 9 commits into
Open
London | 26-ITP-Sep | Mars Adesina | Sprint 1 | Form Controls#1498marscancode wants to merge 9 commits into
marscancode wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
marscancode
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
marscancode
changed the title
marscancode
added
Needs Review
abdishakoor-dev
left a comment
abdishakoor-dev
left a comment
Contributor
There was a problem hiding this comment.
All the requirements are met, the form works and the file is clean: validator and Prettier both pass. Good commits too, one per step.
One inline note for next time, not a blocker. Marking this Complete.
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
| <!-- <objectives> |
Contributor
There was a problem hiding this comment.
The checklist comments here and on lines 20 and 37 were useful while you worked, but now everything is ticked they're the README pasted into the page. Comments in the code are for whoever reads the code later. A checklist like this belongs in the PR description, which you've already written well.
Author
There was a problem hiding this comment.
Thank you Abdi! I'll remove the checklist comments from my code and make sure not to do the same thing with the upcoming coursework.
abdishakoor-dev
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
London | 26-ITP-Sep | Mars Adesina | Sprint 1 | Form Controls
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist
Created a T-shirt order form using HTML with:
I created a form in HTML using form validation, where customers have to enter a required valid name and a required valid email. They also have to choose from three T-shirt colour options and one of six T-shirt sizes. I tested the form using DevTools, including Lighthouse, and the W3C validator. I received a Lighthouse Accessibility score of 100 and no errors after refactoring my requirements, indentation, and HTML semantics.