-
-
Notifications
You must be signed in to change notification settings - Fork 546
Cape Town | 25-ITP-May | Asanda Dunn | Sprint 2 | Wireframe #1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,9 @@ body { | |
| background: var(--paper); | ||
| color: var(--ink); | ||
| font: var(--font); | ||
| margin:0; | ||
| padding:20px; | ||
| padding-bottom:80px; | ||
| } | ||
| a { | ||
| padding: var(--space); | ||
|
|
@@ -40,19 +43,25 @@ img, | |
| svg { | ||
| width: 100%; | ||
| object-fit: cover; | ||
| display:block | ||
| } | ||
| /* ====== Site Layout ====== | ||
| Setting the overall rules for page regions | ||
| https://www.w3.org/WAI/tutorials/page-structure/regions/ | ||
| */ | ||
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
|
|
||
|
|
||
| h1 { | ||
|
|
||
| text-align: center; | ||
| } | ||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
| width: 100%; | ||
| padding:10px; | ||
| text-align: center; | ||
| position: fixed; | ||
| background-color: white; | ||
| } | ||
| /* ====== Articles Grid Layout ==== | ||
| Setting the rules for how articles are placed in the main element. | ||
|
|
@@ -65,10 +74,18 @@ main { | |
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: var(--space); | ||
| > *:first-child { | ||
| align-items: stretch; | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
|
|
||
| } | ||
| main article:first-child img{ | ||
| height:300px; | ||
| } | ||
|
|
||
| main > *:first-child { | ||
| grid-column: span 2; | ||
| } | ||
| } | ||
| /* ====== Article Layout ====== | ||
| Setting the rules for how elements are placed in the article. | ||
| Now laying out just the INSIDE of the repeated card/article design. | ||
|
|
@@ -79,11 +96,21 @@ article { | |
| padding-bottom: var(--space); | ||
| text-align: left; | ||
| display: grid; | ||
| background: white; | ||
|
|
||
| grid-template-columns: var(--space) 1fr var(--space); | ||
| > * { | ||
| grid-template-rows:auto auto 1fr auto; | ||
| } | ||
| article >*{ | ||
| grid-column: 2/3; | ||
| } | ||
| > img { | ||
| article > img { | ||
| grid-column: span 3; | ||
| } | ||
| article p { | ||
| margin-bottom: 0; | ||
| } | ||
| article a { | ||
| margin-top:20px; | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indentation is off. Can you follow the instructions in this guide to enable VS Code's
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for the review. I have fixed the indentation and the image height on articles 2 & 3 |
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.