London | 26-ITP-May | Edina Kurdi | Sprint 3 | Todo List

[edinakurdi]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

• added button to index.html
• implemented deleteCompleted() in todos.mjs
• wrote Jest test in todos.test.mjs
• added event listener in script.mjs

[hackertainment]

Good try, and keep it up :-)

[edinakurdi]

Good try, and keep it up :-)

Thank you. Can you please provide some comments as to what to improve on?

[hackertainment]

Oh, I commented directly with the corresponding lines of code. Two fixes required as shown in above. Thank you.

[hackertainment]

From what I can see, your code looks fairly clean and tidy. So I have no further suggestion on the coding part itself. Just I would be interested with your development/thinking process. Maybe when you have time in the future, try to book a pair-programming section with a mentor, so as to add the implementation of the optional deadline feature into this exercise. :-)

[edinakurdi]

From what I can see, your code looks fairly clean and tidy. So I have no further suggestion on the coding part itself. Just I would be interested with your development/thinking process. Maybe when you have time in the future, try to book a pair-programming section with a mentor, so as to add the implementation of the optional deadline feature into this exercise. :-)

Oh, I was going back and forth - got myself very confused with the code! Didnt realise that this was accepted in the meanwhile. Soulds like a good idea about the deadline feature, ill try and do that! Thank you.