Skip to content

London | 26-ITP-May | Tomislav Dukez | Sprint 3 | Alarm Clock#1305

Open
tomdu3 wants to merge 10 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-3/3-alarm-clock
Open

London | 26-ITP-May | Tomislav Dukez | Sprint 3 | Alarm Clock#1305
tomdu3 wants to merge 10 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-3/3-alarm-clock

Conversation

@tomdu3

@tomdu3 tomdu3 commented Jul 27, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • added alarm clock - mandatory functionalities
  • added flash effect to the background + button to turn it off - extra task
  • added pause - button and functionality - extra task

@tomdu3 tomdu3 added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Jul 27, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 27, 2026
LonMcGregor
LonMcGregor reviewed Jul 27, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, some areas for you to improve your code however

Comment thread Sprint-3/alarmclock/alarmclock.js Outdated
Comment thread Sprint-3/alarmclock/alarmclock.js
Comment thread Sprint-3/alarmclock/alarmclock.js Outdated
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 27, 2026
@tomdu3 tomdu3 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 27, 2026
@LonMcGregor

LonMcGregor commented Jul 27, 2026

Copy link
Copy Markdown

Great work meeting all the requirements here

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 🏕 Priority Mandatory This work is expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomdu3 @LonMcGregor