Skip to content

London | 26-ITP-May | Tomislav Dukez | Sprint 3 | Quote Generator#1282

Open
tomdu3 wants to merge 9 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-3/1-quote-generator
Open

London | 26-ITP-May | Tomislav Dukez | Sprint 3 | Quote Generator#1282
tomdu3 wants to merge 9 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-3/1-quote-generator

Conversation

@tomdu3

@tomdu3 tomdu3 commented Jul 23, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • added function for random quote appears on page load
  • added function for random quote generated when clicked on the button
  • added function for autoplay quotes
  • added styling for the cartoonish style web page look

@tomdu3 tomdu3 added 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Jul 23, 2026
@tomdu3 tomdu3 mentioned this pull request Jul 27, 2026
Open
5 tasks
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 27, 2026
LonMcGregor
LonMcGregor reviewed Jul 27, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I have just one suggestion for improvements

Comment thread Sprint-3/quote-generator/style.css
Comment thread Sprint-3/quote-generator/quotes.js Outdated
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 27, 2026
@tomdu3 tomdu3 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Data-Groups The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomdu3 @LonMcGregor