West Midlands | ITP-May-2026 | Alina Sofragiu | Sprint 3 | alarm clock#1267
Open
sofragiualina wants to merge 2 commits into
Open
West Midlands | ITP-May-2026 | Alina Sofragiu | Sprint 3 | alarm clock#1267sofragiualina wants to merge 2 commits into
sofragiualina wants to merge 2 commits into
Conversation
sofragiualina
added
📅 Sprint 3
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, just one small thing to check
| `Time Remaining: ${formattedMinutes}:${formattedSeconds}`; | ||
| } | ||
|
|
||
| function setAlarm() { |
There was a problem hiding this comment.
Have you done appropriate input validation on the input time?
Author
There was a problem hiding this comment.
I didn’t add input validation before but I’ve now updated it to validate the input before starting the timer it only allows valid positive numbers
LonMcGregor
added
Reviewed
Added input validation for alarm time input.
sofragiualina
added
Needs Review
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great, the alarm clock is complete now
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Alarm clock implementation with timer and sound controls