West Midlands | ITP-May-2026 | Alina Sofragiu | Sprint 2 | Exercises#1264
Open
sofragiualina wants to merge 3 commits into
Open
West Midlands | ITP-May-2026 | Alina Sofragiu | Sprint 2 | Exercises#1264sofragiualina wants to merge 3 commits into
sofragiualina wants to merge 3 commits into
Conversation
sofragiualina
added
📅 Sprint 2
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Jul 27, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Nice work overall, one minor fix regarding validation.
| return queryParams; | ||
| } | ||
|
|
||
| const keyValuePairs = queryString.split("&"); |
There was a problem hiding this comment.
What will happen if a number is passed to the function?
Author
There was a problem hiding this comment.
I’ve added a type check to handle non string inputs and added a test for when a number is passed to prevent the TypeError Thank you for suggestion
hey-hammad
added
Reviewed
sofragiualina
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed sprint 2 exercises