Skip to content

Manchester | 26-ITP-Jan | khalidbih | Sprint 3 | Quote Generator - #1130

Closed
khalidbih wants to merge 2 commits into
CodeYourFuture:mainfrom
khalidbih:Sprint-3/quote-generator
Closed

Manchester | 26-ITP-Jan | khalidbih | Sprint 3 | Quote Generator#1130
khalidbih wants to merge 2 commits into
CodeYourFuture:mainfrom
khalidbih:Sprint-3/quote-generator

Conversation

@khalidbih

@khalidbih khalidbih commented Mar 28, 2026

Copy link
Copy Markdown

Self checklist :

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist :

Added a Quote Generator app that displays random quotes and updates on button click.

@khalidbih khalidbih added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Mar 28, 2026
@khalidbih khalidbih changed the title Manchester | 26-ITP-Jan | | Sprint 3 | Quote Generator Manchester | 26-ITP-Jan | khalidbih | Sprint 3 | Quote Generator Mar 28, 2026
Luro91
Luro91 approved these changes Apr 6, 2026
View reviewed changes

@Luro91 Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. The code works as expected

@Luro91 Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 6, 2026
@Luro91

Luro91 commented Apr 6, 2026

Copy link
Copy Markdown

I just noticed the title of the html page should be "Quote generator app"

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Complete Volunteer to add when work is complete and all review comments have been addressed. labels Apr 6, 2026
@khalidbih

khalidbih commented Apr 6, 2026

Copy link
Copy Markdown
Author

I just noticed the title of the html page should be "Quote generator app"

I’ve fixed the HTML title as requested. Thank you for your feedback.

@khalidbih

khalidbih commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Well done. The code works as expected

Thank you so much. @Luro91

@khalidbih khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 6, 2026
@Luro91 Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 6, 2026
@khalidbih khalidbih mentioned this pull request Apr 9, 2026
Open
@illicitonion

illicitonion commented May 4, 2026

Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Luro91 Luro91 Luro91 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khalidbih @Luro91 @illicitonion