Skip to content

London | 26-ITP-Jan | Miriam Jorna | Sprint 1 | Data Groups - #1126

Closed
miriamjorna wants to merge 5 commits into
CodeYourFuture:mainfrom
miriamjorna:DataGroupsSprint1
Closed

London | 26-ITP-Jan | Miriam Jorna | Sprint 1 | Data Groups#1126
miriamjorna wants to merge 5 commits into
CodeYourFuture:mainfrom
miriamjorna:DataGroupsSprint1

Conversation

@miriamjorna

@miriamjorna miriamjorna commented Mar 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Have done the exercises for the Sprint-1 homework.
Thank you for your time reviewing!

@miriamjorna miriamjorna added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. Core This is a core task and should be completed by all trainees labels Mar 27, 2026
cjyuan
cjyuan reviewed Mar 31, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed updating Sprint-1/refactor/includes.js.

Comment thread Sprint-1/fix/median.js Outdated
Comment thread Sprint-1/implement/dedupe.test.js
Comment thread Sprint-1/implement/max.test.js
Comment thread Sprint-1/implement/sum.test.js
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 31, 2026
@miriamjorna

miriamjorna commented Apr 1, 2026

Copy link
Copy Markdown
Author

Hm hm hmmm I had a nagging feeling I did not grasp the subject entirely and this does prove I need to put more time into rehashing it. Many thanks. It will take a bit of time to resubmit.

@miriamjorna

miriamjorna commented Apr 10, 2026

Copy link
Copy Markdown
Author

Apologies for taking so long. Finally ready for review, including the initially forgotten refactoring exercise.

@miriamjorna miriamjorna added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 10, 2026
@cjyuan

cjyuan commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 10, 2026
@illicitonion

illicitonion commented May 4, 2026

Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Core This is a core task and should be completed by all trainees Module-Data-Groups The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miriamjorna @cjyuan @illicitonion