Skip to content

London | 26-ITP-Sep | Ebrahim Moqbel | sprint 3 | programmer humourr - #589

Open
Ebrahim-Moqbel wants to merge 1 commit into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:programmer-humour
Open

Ebrahim-Moqbel wants to merge 1 commit into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:programmer-humour

Conversation

@Ebrahim-Moqbel

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1134

Changelist

Added the fetchComic fucntion to retrieve the latest comic from the API provided.
Hunddled the error for failed requests
Rendered the return comic images
Added a message if the fetch failed.

@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to incorporate the error message onto the page this way. Good work, task complete

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants