London | 26-ITP-May | Chun Yan Wong | Sprint 2 | Book library - #525
Open
cywong-dev wants to merge 14 commits into
Open
London | 26-ITP-May | Chun Yan Wong | Sprint 2 | Book library#525cywong-dev wants to merge 14 commits into
cywong-dev wants to merge 14 commits into
Conversation
for the function submit
for typo mistake
Fix variable name for delete button in script.js
There is no event called clicks
for wrong insertion order
Read/unread saves the wrong answer
Fix the sequence
Remove newline characters; Change "127" to 127 ; Simplify two push statement to one push statement
Refactor submit function to improve input validation.
Refactor row deletion logic to use while loop for clarity.
Refactor loop to directly use myLibrary.length and simplify read status button logic.
Removed the call to render() when initializing the library.
cywong-dev
added
Needs Review
cjyuan
reviewed
Aug 7, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
The checkboxes in the PR description are not yet properly marked up in Markdown syntax.
-
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.mdDoing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
[X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[X] My changes meet the requirements of the task
[X] I have tested my changes
[X] My changes follow the style guide
Changelist
This PR provides the answer for the coursework book library