Glasgow | 26-ITP-May | Niangh Ciang | Sprint 2 | Book Library - #515
Open
Niangh-Ciang wants to merge 19 commits into
Open
Glasgow | 26-ITP-May | Niangh Ciang | Sprint 2 | Book Library#515Niangh-Ciang wants to merge 19 commits into
Niangh-Ciang wants to merge 19 commits into
Conversation
…layed on the page
Niangh-Ciang
added
📅 Sprint 2
cjyuan
reviewed
Aug 6, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
…ang/Module-Data-Flows into book-library-debugging
Author
|
I’ve gone through the general feedback and made the improvements. |
Niangh-Ciang
added
Needs Review
cjyuan
reviewed
Aug 6, 2026
cjyuan
added
Reviewed
Author
|
I have made improvements to my code. |
Niangh-Ciang
added
Needs Review
cjyuan
reviewed
Aug 7, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. Well done.
Comment on lines
+58
to
+59
| min="1" | ||
| step="1" |
Contributor
There was a problem hiding this comment.
My bad. default step value is already 1. So even without explicitly setting step="1", the input element will only accept whole number.
| pages.value == null || | ||
| pages.value == "" | ||
| ) { | ||
| document.getElementById("submitBtn").addEventListener("click", submit); |
Contributor
There was a problem hiding this comment.
Better practice to keep all the code that needs to be executed once on page load together. Doing so makes it easier to find out what the app does on page load.
| return; | ||
| } | ||
|
|
||
| if (!pagesValue || isNaN(pagesValue) || pagesValue <= 0) { |
Contributor
There was a problem hiding this comment.
Could also replace the first two checks by !Number.isInteger(pagesvalue).
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed fixing all bugs in the Book Library project.