Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 2 | Book-library - #507
Open
meneogbemi42-bit wants to merge 6 commits into
Open
Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 2 | Book-library#507meneogbemi42-bit wants to merge 6 commits into
meneogbemi42-bit wants to merge 6 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
changed the title
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
meneogbemi42-bit
changed the title
meneogbemi42-bit
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
changed the title
meneogbemi42-bit
added
the
Needs Review
cjyuan
reviewed
Aug 5, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
added 3 commits
August 5, 2026 07:54
meneogbemi42-bit
added
Needs Review
cjyuan
reviewed
Aug 5, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
It's a major overhaul of the original code! The code looks solid. I just have a few comments.
Comment on lines
241
to
248
| document.addEventListener("DOMContentLoaded", () => { | ||
| loadLibraryFromStorage(); | ||
| render(); | ||
| }); | ||
|
|
||
| if (bookForm) { | ||
| bookForm.addEventListener("submit", handleFormSubmit); | ||
| } |
Contributor
There was a problem hiding this comment.
Could also include the if-statement in the callback on lines 241-245.
cjyuan
added
Reviewed
meneogbemi42-bit
added
Needs Review
cjyuan
reviewed
Aug 6, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look great. Well done!
Comment on lines
+165
to
+167
| const tempDiv = document.createElement("div"); | ||
| tempDiv.textContent = book.title; | ||
| showNotification(`"${tempDiv.innerHTML}" added to your library.`, "success"); |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
this PR fixes several bugs and improves the Book Library UI logic in debugging/book-library/script.js — it corrects typos, tightens form validation, ensures new books are created with the correct author and stored in the right array, clears the form after submit, and fixes the table-rendering and read/delete button behavior.