Skip to content

London | May-26 | Liridona Shehu | Sprint 2 | Book Library #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shehu-dona wants to merge 8 commits into
base: main
Choose a base branch
from
+67 −91
Open

London | May-26 | Liridona Shehu | Sprint 2 | Book Library #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1cddaaa
Introduce yourself destructuring object
dona-shehu Jul 29, 2026
c92876e
gryffindor and teacherWithPet, destructuring array of objects
dona-shehu Jul 29, 2026
7155b0b
Reversing changes on main.
dona-shehu Jul 29, 2026
42348b4
fixed author ,add closing braked, changed the check to true, changed …
dona-shehu Aug 2, 2026
9b12fa3
Revert unintended whitespace changes to exercise-1 and exercise-2
dona-shehu Aug 2, 2026
3edd224
updated index.html following the guide
dona-shehu Aug 3, 2026
1f6ee38
updated the script following the guide
dona-shehu Aug 3, 2026
0e972b2
updated the style following the guide
dona-shehu Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 11 additions & 25 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<meta charset="utf-8" />
<title>Book Library</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -31,15 +28,15 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand All @@ -51,6 +48,7 @@ <h1>Library</h1>
class="form-control"
id="pages"
name="pages"
min="1"
required
/>
<label class="form-check-label">
Expand All @@ -61,15 +59,11 @@ <h1>Library</h1>
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
<button type="button" id="submitBtn" class="btn btn-primary">
Submit
</button>
</div>
</div>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
Expand All @@ -80,17 +74,9 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
<tbody id="displayBody"></tbody>
</table>

<script src="script.js"></script>
<script src="script.js" type="module"></script>
</body>
</html>
120 changes: 55 additions & 65 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,41 +6,39 @@ window.addEventListener("load", function (e) {
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
if (myLibrary.length === 0) {
myLibrary.push(new Book("Robison Crusoe", "Daniel Defoe", 252, true));
myLibrary.push(
new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true)
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
document.getElementById("submitBtn").addEventListener("click", submit);

@cjyuan cjyuan Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Common practice is to organise the code in the following manner:

// Declaration of constants and variables

// Function definitions

// Code to be executed

const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
const titleVal = titleInput.value.trim();
const authorVal = authorInput.value.trim();
const pagesVal = Number(pagesInput.value);

if (!titleVal || !pagesVal || pagesVal <= 0) {
alert("Please fill all fields with valid values!");
return;
}
Comment on lines +29 to 32

@cjyuan cjyuan Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could not be certain the input is always a whole number, we should also check that condition.


const book = new Book(titleVal, authorVal, pagesVal, checkInput.checked);
myLibrary.push(book);
render();

titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
checkInput.checked = false;
}

function Book(title, author, pages, check) {
Expand All @@ -51,53 +49,45 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
const tbody = document.getElementById("displayBody");
tbody.innerHTML = "";

//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
for (let i = 0; i < myLibrary.length; i++) {
const book = myLibrary[i];
const row = tbody.insertRow();

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);
titleCell.textContent = book.title;
authorCell.textContent = book.author;
pagesCell.textContent = book.pages;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
//add and wait for action for read/unread button
const markReadButton = document.createElement("button");
markReadButton.className = "btn btn-success";
markReadButton.textContent = book.check ? "Yes" : "No";
markReadButton.addEventListener("click", function () {
book.check = !book.check;
render();
});

wasReadCell.appendChild(markReadButton);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const deleteButton = document.createElement("button");
deleteButton.className = "btn btn-warning";
deleteButton.textContent = "Delete";
deleteButton.addEventListener("click", function () {
const deletedTitle = book.title;
myLibrary.splice(i, 1);
render();
console.log(`You've deleted title: ${deletedTitle}`);

@cjyuan cjyuan Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not quite show the message to the user.

Suggestion: Look up a non-blocking approach to show messages.

});

deleteCell.appendChild(deleteButton);
}
}
2 changes: 1 addition & 1 deletion debugging/book-library/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.form-group {
width: 400px;
height: 300px;
align-self: left;
align-self: start;
padding-left: 20px;
}

Expand Down