Skip to content

London | Jan26 | Ihor Taradaiko | Sprint 2 | Book Library#452

Closed
ihortar wants to merge 5 commits into
CodeYourFuture:mainfrom
ihortar:book-library
Closed

London | Jan26 | Ihor Taradaiko | Sprint 2 | Book Library#452
ihortar wants to merge 5 commits into
CodeYourFuture:mainfrom
ihortar:book-library

Conversation

@ihortar

@ihortar ihortar commented Apr 16, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Fixed:

  1. Website loads but doesn't show any books
  2. Error in console when you try to add a book
  3. It uses the title name as the author name
  4. Delete button is broken
  5. When I add a book that I say I've read - it saves the wrong answer

@ihortar ihortar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Apr 20, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the latest comment instead.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 20, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already have a good start.

Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
@ihortar ihortar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 20, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

I will mark this as Complete first.

let book = new Book(
cleanedTitle,
cleanedAuthor,
Number(cleanedPages),

@cjyuan cjyuan Apr 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When dealing with number input, we should consider its possible type and range.
Have you checked if Number(cleanedPages) is a positive integer ?

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 20, 2026
@illicitonion

Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants