London | 26-ITP-Jan | Carlos Abreu |Sprint 2 | Book Library

[carlosyabreu]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Book library's PR

[cjyuan]

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

[carlosyabreu]

@cjyuan
Following the general feedback link you provided, I made minor HTML fix.
In index.html, I changed the author input from type="author" to type="text" and checked required is present.
Also, I added min="1" to the pages input.


To truly isolate scope I did:
Remove onclick="submit();" from the submit button.
Add type="module" to the script tag.
Inside script.js, I used document.querySelector(...).addEventListener("click", submit).
That change in script.js made it possible to work with type="module".
Therefore, the script no longer rely on a global submit() function. Instead, we attach an event listener inside the module.
We refactored the coding (script) and made minor changes in index.html and pushed it again to GitHub.
I checked the HTML code on (https://validator.w3.org/) it passes the test with no errors.

[cjyuan]

Changes look good.

[cjyuan]

Safer to declare this using const, as myLibrary should not be reassigned a new value.

[cjyuan]

You didn't use any form in HTML though.

[illicitonion]

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.