Glasgow | 26-ITP-Jan| Martin McLean |Sprint 2|Book Library#448
Closed
mjm-git185 wants to merge 7 commits into
Closed
Glasgow | 26-ITP-Jan| Martin McLean |Sprint 2|Book Library#448mjm-git185 wants to merge 7 commits into
mjm-git185 wants to merge 7 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
mjm-git185
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
mjm-git185
changed the title
mjm-git185
added
Review in progress
cjyuan
reviewed
Apr 16, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
mjm-git185
added
the
Needs Review
cjyuan
reviewed
Apr 17, 2026
Comment on lines
+79
to
+82
| myLibrary[i].check == true | ||
| ? (readStatus = "Yes") | ||
| : (readStatus = "No"); | ||
|
|
Contributor
There was a problem hiding this comment.
Normally way to use ? : is:
readStatus = myLibrary[i].check ? "Yes" : "No";
condition ? v1 : v2is an expression. It evaluates tov1ifconditionis true, and tov2if conditionis false..checkis a boolean value. Comparing it totrueis optional.
cjyuan
removed
the
Needs Review
mjm-git185
added
the
Needs Review
cjyuan
reviewed
Apr 18, 2026
Comment on lines
+26
to
+27
| const titleInput = document.getElementById("title").value.trimStart(); | ||
| const authorInput = document.getElementById("author").value.trimStart(); |
| table.deleteRow(n); | ||
| while (table.rows.length > 1) { | ||
| table.deleteRow(1); | ||
| } |
Contributor
There was a problem hiding this comment.
Clearing <tbody> is probably easier and more efficient.
cjyuan
removed
the
Needs Review
mjm-git185
added
the
Needs Review
cjyuan
reviewed
Apr 18, 2026
|
|
||
| function submit() { | ||
| const titleInput = document.getElementById("title").value.trim(); | ||
| const authorInput = document.getElementById("author").value.trimStart(); |
Contributor
There was a problem hiding this comment.
Why not also trim the trailing space in author's name?
cjyuan
removed
the
Needs Review
mjm-git185
added
the
Needs Review
cjyuan
removed
the
Reviewed
cjyuan
added
Complete
Author
|
Thanks for all your help |
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
my coursework