Manchester | ITP Jan-26 | Ofonime Edak | Sprint 2 | Book library#441
Closed
Ofonimeedak wants to merge 5 commits into
Closed
Manchester | ITP Jan-26 | Ofonime Edak | Sprint 2 | Book library#441Ofonimeedak wants to merge 5 commits into
Ofonimeedak wants to merge 5 commits into
Conversation
Ofonimeedak
added
📅 Sprint 2
cjyuan
reviewed
Apr 16, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
Ofonimeedak
added
the
Needs Review
cjyuan
reviewed
Apr 19, 2026
|
|
||
| //add delete button to every row and render again | ||
|
|
||
| let delButton = document.createElement("button"); |
Contributor
There was a problem hiding this comment.
Could consider declaring the two buttons using const.
cjyuan
removed
the
Needs Review
Ofonimeedak
added
the
Needs Review
Contributor
|
Changes look good. |
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Debug and fix errors in the book library app