London | 26-ITP-Jan | Said Fayaz Sadat | Sprint 2 | Book Library#438
Closed
fayaz551 wants to merge 7 commits into
Closed
London | 26-ITP-Jan | Said Fayaz Sadat | Sprint 2 | Book Library#438fayaz551 wants to merge 7 commits into
fayaz551 wants to merge 7 commits into
Conversation
- Corrected variable reference from 'library' to 'myLibrary'. - Fixed logic bug where title input was being used for the author field. - Fixed delete button functionality and event listener naming. - Corrected read status display logic to show "Yes" when checked.
- Changed input types for title and author to 'text' for standard validation. - Ensured script and bootstrap links are correctly ordered for DOM loading.
- Adjusted form-group dimensions for better visibility. - Added spacing and alignment for table action buttons.
This comment has been minimized.
This comment has been minimized.
fayaz551
changed the title
This comment has been minimized.
This comment has been minimized.
Contributor
|
Your PR title is in the wrong format. That's why the validation bot could not recognise it. |
fayaz551
changed the title
This comment has been minimized.
This comment has been minimized.
fayaz551
changed the title
Author
Changed the title to correct format, validation passed now. |
cjyuan
reviewed
Apr 17, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
You have fixed the explicit bugs, but the code still have some rooms to improve.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
the
Reviewed
fayaz551
added
Needs Review
cjyuan
reviewed
Apr 18, 2026
cjyuan
added
Reviewed
fayaz551
added
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
fixed bugs and implemented the fixes
Questions
n/a