Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 2 | Book Library

[Richiealx]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

This PR fixes the bugs in the Book Library debugging project for Sprint 2 of the Data Flows module.

Changes made:

• fixed initial rendering so books display on page load
• fixed form submission so new books are added to myLibrary
• fixed validation to require title, author, and a valid page count
• fixed author field bug so the correct author is stored
• stored page count as a number instead of a string
• fixed read status so it displays correctly
• fixed toggle button behaviour for read/unread
• fixed delete functionality so books are removed correctly
• improved variable naming for DOM elements
• cleaned up table rendering to use tbody
• corrected invalid HTML input types and improved basic HTML validation

[cjyuan]

Looks good. Well done.

[cjyuan]

Could declare this using const.

[illicitonion]

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.