Skip to content

Birmingham | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | Book Library - #428

Closed
tasleemadedokun wants to merge 15 commits into
CodeYourFuture:mainfrom
tasleemadedokun:debugging-book-library
Closed

Birmingham | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | Book Library#428
tasleemadedokun wants to merge 15 commits into
CodeYourFuture:mainfrom
tasleemadedokun:debugging-book-library

Conversation

@tasleemadedokun

@tasleemadedokun tasleemadedokun commented Apr 13, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Brief:
I have made several commits and fixed the bugs to the best of my ability.

@tasleemadedokun tasleemadedokun added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Apr 13, 2026
cjyuan
cjyuan reviewed Apr 16, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 16, 2026
@tasleemadedokun
Update html, buy adding title name Library, improve meta tag, ensure …
2cad409 
…html validation with required, pattern and min, also load script with type module.
@tasleemadedokun
Update new script.js
b8f4d08
@tasleemadedokun tasleemadedokun added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 16, 2026
@tasleemadedokun

tasleemadedokun commented Apr 16, 2026

Copy link
Copy Markdown
Author

Can you check if any of this general feedback can help you further improve your code? https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

Hi, I have updated it. Thanks

@tasleemadedokun
tasleemadedokun requested a review from cjyuan April 16, 2026 16:15
cjyuan
cjyuan reviewed Apr 16, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other changes look good.

Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment on lines +56 to +66
const table = document.getElementById("display");

table.innerHTML = `
<tr>
<th>Title</th>
<th>Author</th>
<th>Pages</th>
<th>Read</th>
<th>Delete</th>
</tr>
`;

@cjyuan cjyuan Apr 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also just clear <tbody>.

@tasleemadedokun tasleemadedokun Apr 16, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, I have addressed all once and for all.
Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 16, 2026
@tasleemadedokun tasleemadedokun added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 16, 2026
@tasleemadedokun
tasleemadedokun requested a review from cjyuan April 16, 2026 19:32
@cjyuan

cjyuan commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 17, 2026
@tasleemadedokun

tasleemadedokun commented Apr 17, 2026

Copy link
Copy Markdown
Author

Changes look good. Well done.

Thank you very much .

@tasleemadedokun tasleemadedokun mentioned this pull request Apr 19, 2026
Open
@illicitonion

illicitonion commented May 4, 2026

Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan Awaiting requested review from cjyuan

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tasleemadedokun @cjyuan @illicitonion