Skip to content

Cape Town | 2026-ITP-Jan | Isaac Abodunrin | Sprint 2 | Data Flows: Book Library Project #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bytesandroses wants to merge 22 commits into from
Closed

Cape Town | 2026-ITP-Jan | Isaac Abodunrin | Sprint 2 | Data Flows: Book Library Project #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a1682cb
Fix: allow books to display by correcting syntax errors
bytesandroses Apr 12, 2026
e75af87
Fix: allow new books to be added
bytesandroses Apr 12, 2026
3fd4d7a
Fix: display correct author name, and not title
bytesandroses Apr 12, 2026
52b0d0b
Fix: allow books to be deleted by correcting syntax error
bytesandroses Apr 12, 2026
d751fcc
Fix: save checked status correctly
bytesandroses Apr 12, 2026
687952b
Fix: correct syntax errors in HTML
bytesandroses Apr 19, 2026
f75c49b
Modularize and isolate script.js
bytesandroses Apr 19, 2026
92f9595
Fix: add event listener for submitting new book
bytesandroses Apr 19, 2026
ea811f6
Style: clear the form after a new book is added
bytesandroses Apr 19, 2026
58a38fa
Fix: correct read label status
bytesandroses Apr 19, 2026
ba8fc04
Validate input before form is submitted
bytesandroses Apr 20, 2026
672ec4e
Fix: correctly add new books into library
bytesandroses Apr 20, 2026
bad4502
Refactor: remove duplicate rendering
bytesandroses Apr 20, 2026
c4cd9b4
Refactor: remove duplicate forms input validation
bytesandroses Apr 20, 2026
1b9ec8e
Refactor: remove unneccessary id labelling
bytesandroses Apr 20, 2026
5f43e96
Refactor: simplify repetitive code
bytesandroses Apr 20, 2026
b8786ad
Refactor: simplify render function
bytesandroses Apr 20, 2026
0e8dec0
Refactor: treat page count as an integer throughout
bytesandroses Apr 20, 2026
5a768e1
Refactor: improve readbility with more descriptive variable names
bytesandroses Apr 20, 2026
b72bd52
Refactor: sanitize form input to remove uneccessary white spaces
bytesandroses Apr 20, 2026
2b390dc
Refactor: display alert message only after successful deletion
bytesandroses Apr 20, 2026
314fb76
Refactor: declare myLibrary with const instead of let
bytesandroses Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 50 additions & 48 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
<!DOCTYPE html>
<html>
<!doctype html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>Virtual Book Library</title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -28,46 +25,51 @@ <h1>Library</h1>
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<form id="bookForm">
<div class="form-group">
<label for="title">Title:</label>
<input
type="text"
class="form-control"
id="title"
name="title"
required
minlength="1"
maxlength="40"
pattern=".*\S+.*"
/>
<label for="author">Author: </label>
<input
type="text"
class="form-control"
id="author"
name="author"
required
minlength="1"
maxlength="40"
pattern=".*\S+.*"
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
min="1"
max="2000"
/>
<label class="form-check-label">
<input type="checkbox" class="form-check-input" id="check" />Read
</label>
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
type="submit"
value="Submit"
class="btn btn-primary"
id="submitBtn"
/>
</div>
</form>
</div>

<table class="table" id="display">
Expand All @@ -91,6 +93,6 @@ <h1>Library</h1>
</tbody>
</table>

<script src="script.js"></script>
<script src="script.js" type="module"></script>
</body>
</html>
122 changes: 53 additions & 69 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
Expand All @@ -7,41 +7,37 @@ window.addEventListener("load", function (e) {

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
myLibrary.push(book1, book2);
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");
Comment on lines +21 to +24

@cjyuan cjyuan Apr 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common practice is to declare all shared variables/constants at the beginning of the file before function definition.


//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}
}
const submitForm = document.getElementById("bookForm");
submitForm.addEventListener("submit", function (e) {
e.preventDefault();

let book = new Book(
titleInput.value.trim(),
authorInput.value.trim(),
parseInt(pagesInput.value),
checkInput.checked
);
myLibrary.push(book);
submitForm.reset();

render();
});

@cjyuan cjyuan Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider keeping all the "run on page load" code in one place (in the call back of window's onload event listener) as:

const submitForm = document.getElementById("bookForm"); // declare at the top
...

// function definition
function submit(e) {
  ...
}

window.addEventListener('load', () => {
  submitForm.addEventListener("submit", submit);
  populateStorage();
  render();
});


function Book(title, author, pages, check) {
this.title = title;
Expand All @@ -51,53 +47,41 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const tbody = document.querySelector("#display tbody");
// Clear existing rows
tbody.innerHTML = "";

myLibrary.forEach((book, index) => {
// Create a new row and cells for each book
const row = tbody.insertRow();
row.insertCell(0).textContent = book.title;
row.insertCell(1).textContent = book.author;
row.insertCell(2).textContent = book.pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
const wasReadCell = row.insertCell(3);
const readBtn = document.createElement("button");
readBtn.className = "btn btn-success";
readBtn.textContent = book.check ? "Yes" : "No";

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
// Toggle the read status when the button is clicked
readBtn.addEventListener("click", () => {
book.check = !book.check;
render();
});
wasReadCell.appendChild(readBtn);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
// Create a delete button for each book
const deleteCell = row.insertCell(4);
const deleteBtn = document.createElement("button");
deleteBtn.className = "btn btn-warning";
deleteBtn.textContent = "Delete";

// Render the updated library when the delete button is clicked
deleteBtn.addEventListener("click", () => {
myLibrary.splice(index, 1);
alert(`You've deleted title: ${book.title}`);
render();
});
}
deleteCell.appendChild(deleteBtn);
});
}
Loading