Skip to content

London | JAN-ITP-26 | Kayanat Suleman | Sprint 2 | Book Library - #420

Closed
KayanatSuleman wants to merge 9 commits into
CodeYourFuture:mainfrom
KayanatSuleman:feature/debugging
Closed

London | JAN-ITP-26 | Kayanat Suleman | Sprint 2 | Book Library#420
KayanatSuleman wants to merge 9 commits into
CodeYourFuture:mainfrom
KayanatSuleman:feature/debugging

Conversation

@KayanatSuleman

@KayanatSuleman KayanatSuleman commented Apr 11, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed the bug preventing books from rendering on page load
  • Fixed the add book error caused by an incorrect variable reference
  • Fixed the bug where the title was used as the author
  • Fixed the delete button by correcting variable references and event name
  • Fixed the read status logic so the correct value is displayed
  • Updated validation to check for missing author input

@KayanatSuleman KayanatSuleman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Apr 11, 2026
cjyuan
cjyuan reviewed Apr 11, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 11, 2026
@KayanatSuleman

KayanatSuleman commented Apr 12, 2026

Copy link
Copy Markdown
Author

@cjyuan Hi thank you for sharing - I have refactored the code now to based off the general review comments, Please see updated code base. Thank you.

@KayanatSuleman KayanatSuleman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 12, 2026
cjyuan
cjyuan reviewed Apr 12, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Well done.

Comment thread debugging/book-library/script.js
Comment on lines +99 to +110
function showMessage(message) {
let messageBox = document.getElementById("message");

if (!messageBox) {
messageBox = document.createElement("div");
messageBox.id = "message";
messageBox.className = "alert alert-info mt-3";
displayTable.insertAdjacentElement("beforebegin", messageBox);
}

messageBox.textContent = message;
} No newline at end of file

@cjyuan cjyuan Apr 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch.

Currently, once the message is displayed, it does not go away when the user perform other tasks such as adding a new book.

As this is something extra, no change required.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 12, 2026
@KayanatSuleman KayanatSuleman mentioned this pull request Apr 19, 2026
Open
9 tasks
@illicitonion

illicitonion commented May 4, 2026

Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KayanatSuleman @illicitonion @cjyuan