Open
Conversation
Rob--W
reviewed
Oct 27, 2016
Collaborator
Rob--W
left a comment
Rob--W
left a comment
There was a problem hiding this comment.
Thanks for your PR. If you address the following minor comments and squash the changes, then it's ready to be merged,
| defaults to `kwallet`. | ||
| * `CHROMIUM_EXE_PATH` - Set the path to the Chromium / Google Chrome executable. | ||
|
|
||
| * REUSE_XVFB - Default is to start a new Xvfb for each process. Set REUSE_XVFB=true to reuse screen :99 instead. |
Collaborator
There was a problem hiding this comment.
Please keep the line break (add a new line after line 23)
| var xvfb = new Xvfb({ | ||
| silent: true, | ||
| // Check environment variable for reuse | ||
| reuse:(process.env.REUSE_XVFB === "true"), |
Collaborator
There was a problem hiding this comment.
Put a space between reuse: and (.
| // Start the virtual X Framebuffer | ||
| var xvfb = new Xvfb({ | ||
| silent: true, | ||
| // Check environment variable for reuse |
Collaborator
There was a problem hiding this comment.
Remove this comment, it doesn't add anything that is not already obvious from looking at the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor change to allow reusing the same Xvfb screen for multiple processes. Can save resources.