-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change way secrets are stored #675
Open
thejsj
wants to merge
2,593
commits into
master
Choose a base branch
from
change-way-secrets-are-stored
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bucket region for web
Added ability to deploy to marketing again
Change region name
Added s3 log bucket to ansible
…t require variables tied to environment
* remove psad from dock * update charon, add tag for cert
Update gamma ingres proxy k8 configs.
Added keymaker configurations.
…ripts into fix-image-builder-push * 'fix-image-builder-push' of github.com:CodeNow/devops-scripts: update node version to the tested one
* make vault public * add vars for access
Fix tagging of image builder
8d5ab8f
to
2527010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should treat our k8 files as compiled files, since we don't actually (http://blog.andrewray.me/dealing-with-compiled-files-in-git/). We should probably wait some time until we actually have more confidence in our compilation.
What this PR does
/ansible/certs
to/ansible/secrets/certs
/ansible/*.com
) to/ansible/secrets/domains
Ideas
/ansible
)docker-client
andcerts
environment dependent (Currently docker-client certs are shared)secrets
directory to every environment which would have all the correct filesDependencies
Tests
runanble-domain-proxy
content-domain-proxy
Deployment (post-merge)