145 - Correct pesel validation #158
Merged
+88
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafalkufel
requested review from
arturtamborski,
jacekkalbarczyk,
magul,
stanislawK and
w1stler
w1stler
reviewed
Sep 22, 2025
alinka/schemas/document_schema.py
Outdated
| year = 2000 + year_part if month_part > 20 else 1900 + year_part | ||
| month = month_part - 20 if month_part > 20 else month_part | ||
| self.birth_date = date(year, month, day) | ||
| self.birth_date = pesel_to_date_of_birth(pesel) |
There was a problem hiding this comment.
Do we want to check validity of PESEL before extracting date out of it? At this point the data would be correct?
There was a problem hiding this comment.
We have here already validated pesel (either form form, or db). No need to validate it every time.
w1stler
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #145