[1] PR & issue template fixes #1 #2
Conversation
| #### Subject of the issue: | ||
| Describe your issue here | ||
|
|
||
| #### Your environment: |
There was a problem hiding this comment.
Do we need this, while working in docker?
There was a problem hiding this comment.
By environment I meant production / RC / local. I am not sure if deployed envs' configuration will differ.
PULL_REQUEST_TEMPLATE.md
Outdated
| #### Migrations: | ||
| N/A | ||
|
|
||
| #### Rollback: |
There was a problem hiding this comment.
Isn't it too specific? As I understand rollback means reversed migration (does it?), in which case we would hardly ever use that field and even if we do, "Migrations" still seems to be the likely place I would mention it
There was a problem hiding this comment.
Defaultly it would be N/A (or the previous version mentioned), but I would stick with that as a good practice. Nevertheless could be removed. ;-)
|
|
||
| #### Your environment: | ||
| * version/branch | ||
| * which browser and its version |
There was a problem hiding this comment.
I don't think that there's much of use out of it, we can probably assume that every member is using a "recent enough" one.
There was a problem hiding this comment.
Ditto, I would leave it as a good practice.
PULL_REQUEST_TEMPLATE.md
Outdated
| N/A | ||
|
|
||
| #### Unit Tests: | ||
| N/A |
There was a problem hiding this comment.
What does it mean? Should I list unit tests here? Or describe what I (potentially) added to the testing suite?
There was a problem hiding this comment.
When you don't have a habit of writing tests this could be actually self-reflective. "Oh so... I wrote this function so what kind of tests do I need here? Since it is expected to list sth...".
Also this could be early checker for complexity od the code. If you have a lot of those the chance is that you like spaghetti, aren't you? :D
There was a problem hiding this comment.
Hard-copy from other project. :D Could be removed.
| N/A | ||
|
|
||
| #### What tests do I need to run to validate this change: | ||
| N/A |
|
Resolves #1 |
3 participants
No description provided.