Fix macOS 13 compatibility #356
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove asyncAndWait which is unavailable on macOS < 14. Using sync instead, which has equivalent behavior.
0xWDG
approved these changes
Dec 31, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash on macOS 13 by replacing an API that's only available on macOS 14+ with a backward-compatible equivalent. The issue was that asyncAndWait caused dyld to crash at launch on macOS 13 due to hard-linking of unavailable symbols, even when guarded with availability checks.
Key Changes:
- Replace
DispatchQueue.main.asyncAndWait(execute:)withDispatchQueue.main.sync(execute:)which has identical behavior and is available on macOS 13+
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
asyncAndWaitwithsyncto fix crash on macOS 13Problem
DispatchQueue.asyncAndWait(execute:)is only available on macOS 14+. Using#availablecheck doesn't help because the symbol is still hard-linked in the binary, causing dyld to crash at launch on older systems:Solution
Use
DispatchQueue.main.sync(execute:)instead, which has equivalent behavior and is available on all macOS versions.