Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bungee] Change PlayerDisconnectEvent priority to LOWEST #536

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

karer
Copy link

@karer karer commented Mar 17, 2020

Setting server to null could cause problems with other plugins. E.g. with auth, which stores player's latest server in database. It has normal priority and gets current server as 'null', because of BungeeTabListPlus.

This PR:

  1. Changes event priority to lowest,
  2. Removes manual disconnection

... so other plugins get valid info about current server.

@CodeCrafter47
Copy link
Owner

The code you remove is there as a workaround for the following BungeeCord bug: SpigotMC/BungeeCord#1601.

@CodeCrafter47
Copy link
Owner

I'd be okay with the priority change if that helps.

@Phoenix616
Copy link

Just so that nobody pulls this without considering this: Changing the priority from HIGHEST (which means run last) to LOWEST (runs first) would actually cause the issues described as now plugins listening on any higher level (LOW, NORMAL/none specified, HIGH, HIGHEST) would all listen after BTLP disconnects the player. So changing the priority would not solve anything and as it stands right now any plugin listening on anything below HIGHEST should not run into any issues? If they are occurring then someone should provide some example code that actually runs into those issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants