pldm-file, pldm-platform: CRC correctness fixes #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StartAndEnd packets shouldn't include the CRC. Signed-off-by: Matt Johnston <[email protected]>
Signed-off-by: Matt Johnston <[email protected]>
Regarding the part checksum field, DSP0240 says: 32-bit cumulative CRC for the entirety of data received so far for this section (all parts concatenated together, excluding checksums). Shall be included with all part transfers. So, we need to keep the checksum Digest around, and use the cumulative value in responses & response checks. We also shift the comment on restarting from a FIRST_PART, as it was incorrectly placed in the non-restart case. Signed-off-by: Jeremy Kerr <[email protected]>
Since we have FileTransferContext::new(), this doesn't do much, and is infallible. So, just call FileTransferContext::new() directly. Signed-off-by: Jeremy Kerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes from testing against other implementations: