Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling specific sides for human or AI players only #542

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

MortonPL
Copy link
Member

Currently the only way to restrict side selection is via co-op map settings, game mode settings or game option checkboxes. This PR expands the way modders can restrict selection (only for game modes) for human players and computer players separately, using DisallowedHumanPlayerSides and DisallowedComputerPlayerSides.

Example usage in INI/MPMaps.ini:

[Standard]                          ; any game mode section
; (...)
DisallowedPlayerSides=7             ; already exists - disallow sides for all players
DisallowedHumanPlayerSides=1,2,3    ; new - disallow sides for human players only
DisallowedComputerPlayerSides=4,5,6 ; new - disallow sides for computer players only

image

image

Copy link

github-actions bot commented Mar 31, 2024

Nightly build for this pull request:

* Fix bug where only game host was restricted
* Fix bug where AI players weren't restricted as long as any game options or map weren't changed
@MortonPL
Copy link
Member Author

MortonPL commented Apr 3, 2024

Upon further testing, it seems that players joining a multiplayer room still don't respect the new restrictions. This will be addressed in a few days.

@MortonPL MortonPL marked this pull request as draft April 3, 2024 14:20
Ensure there are no bugs in multiplayer lobby
@MortonPL MortonPL marked this pull request as ready for review April 14, 2024 12:59
@MortonPL
Copy link
Member Author

This should be ready for review again.

@mbnq
Copy link

mbnq commented Apr 14, 2024

Works great in BF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants