Fix: fencer: Make the deprecated "stonith-watchdog-timeout" option work again#4068
Open
gao-yan wants to merge 1 commit intoClusterLabs:mainfrom
Open
Fix: fencer: Make the deprecated "stonith-watchdog-timeout" option work again#4068gao-yan wants to merge 1 commit intoClusterLabs:mainfrom
gao-yan wants to merge 1 commit intoClusterLabs:mainfrom
Conversation
…rk again This fixes a regression introduced by d7cc9b4, which has not made it into made it into any release. Even though "stonith-watchdog-timeout" option has become a deprecated alias for "fencing-watchdog-timeout", we need to make sure it still works as a fallback until it's dropped in a future release. Controller's config_query_callback() invokes pcmk__validate_cluster_options(config_hash) beforehand, which handles any settings with deprecated option names. I'll leave the g_hash_table_lookup() calls there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by d7cc9b4, which has not made it into made it into any release. Even though "stonith-watchdog-timeout" option has become a deprecated alias for "fencing-watchdog-timeout", we need to make sure it still works as a fallback until it's dropped in a future release.
Controller's config_query_callback() invokes pcmk__validate_cluster_options(config_hash) beforehand, which handles any settings with deprecated option names. I'll leave the g_hash_table_lookup() calls there.