Fix: fencer: Disable watchdog-based self-fencing if "fencing-watchdog-timeout" is unset#4067
Open
gao-yan wants to merge 1 commit intoClusterLabs:mainfrom
Open
Fix: fencer: Disable watchdog-based self-fencing if "fencing-watchdog-timeout" is unset#4067gao-yan wants to merge 1 commit intoClusterLabs:mainfrom
gao-yan wants to merge 1 commit intoClusterLabs:mainfrom
Conversation
…-timeout" is unset This fixes a regression introduced by 215ad4f, which has not made it into any release.
Contributor
|
Ok, we aren't running multi-threaded in general but do we want to introduce such a pattern - reset global just to set it to the correct value later? |
Member
Author
|
It basically is the default value for all the early returns in below. |
Member
Author
|
But of course we could either do it for each of the early returns if it feels safer that way :-) |
Contributor
|
Well early returns are basically not the best choice if you want to change something global with each return. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by 215ad4f, which has not made it into any release.