Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: crmadmin: return error if DC is not elected #2902 #3606 #3716

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Fix: crmadmin: return error if DC is not elected #2902 #3606 #3716

merged 1 commit into from
Jan 31, 2025

Conversation

aleksei-burlakov
Copy link

@aleksei-burlakov aleksei-burlakov commented Nov 2, 2024 •
edited
Loading

If the DC is not yet elected, the crmadmin will return an error. (This change complements #3606).

@aleksei-burlakov aleksei-burlakov force-pushed the fix-crmadmin-dclookup-return-undetermined branch from a35d796 to aac55a2 Compare November 2, 2024 12:43
kgaillot
kgaillot reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@kgaillot kgaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

lib/pacemaker/pcmk_cluster_queries.c Outdated Show resolved Hide resolved
@aleksei-burlakov aleksei-burlakov force-pushed the fix-crmadmin-dclookup-return-undetermined branch 2 times, most recently from 2f31653 to f0471b5 Compare November 11, 2024 13:45
kgaillot
kgaillot reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@kgaillot kgaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks

include/crm/common/results.h Outdated Show resolved Hide resolved
@aleksei-burlakov aleksei-burlakov force-pushed the fix-crmadmin-dclookup-return-undetermined branch from f0471b5 to 677a7d3 Compare January 17, 2025 11:35
Fix: crmadmin: return error if DC is not elected ClusterLabs#2902 Clu…
a1d94f7 
…sterLabs#3606

If the DC is not yet elected, the crmadmin will return an error.
(This change complements ClusterLabs#3606).
@aleksei-burlakov aleksei-burlakov force-pushed the fix-crmadmin-dclookup-return-undetermined branch from 677a7d3 to a1d94f7 Compare January 18, 2025 15:51
@clumens clumens added the needs attention PRs that someone needs to look at label Jan 30, 2025
@clumens clumens merged commit 5ccb2fa into ClusterLabs:main Jan 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrwahl2 nrwahl2 nrwahl2 left review comments

@kgaillot kgaillot kgaillot left review comments

@clumens clumens clumens approved these changes

Assignees
No one assigned
Labels
needs attention PRs that someone needs to look at
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleksei-burlakov @clumens @kgaillot @nrwahl2