Refactor: libs: Remove existing cppcheck suppressions.

cppcheck runs just fine for me without these, though it's possible a different version of cppcheck would still require them.
ClusterLabs · Feb 17, 2025 · e636645 · e636645
1 parent 77a5fca
commit e636645
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 12 deletions.
diff --git a/include/crm/common/io_internal.h b/include/crm/common/io_internal.h
@@ -53,8 +53,6 @@ void pcmk__close_fds_in_child(bool);
 static inline void
 pcmk__open_devnull(int flags)
 {
-    // Static analysis clutter
-    // cppcheck-suppress leakReturnValNotUsed
     (void) open("/dev/null", flags);
 }
 

diff --git a/lib/cluster/cpg.c b/lib/cluster/cpg.c
@@ -996,8 +996,6 @@ send_cpg_text(const char *data, const pcmk__node_status_t *node,
             msg->compressed_size = new_size;
 
         } else {
-            // cppcheck seems not to understand the abort logic in pcmk__realloc
-            // cppcheck-suppress memleak
             msg = pcmk__realloc(msg, msg->header.size);
             memcpy(msg->data, data, msg->size);
         }

diff --git a/lib/common/cmdline.c b/lib/common/cmdline.c
@@ -107,7 +107,6 @@ pcmk__build_arg_context(pcmk__common_args_t *common_args, const char *fmts,
     }
 
     // main_group is now owned by context, we don't free it here
-    // cppcheck-suppress memleak
     return context;
 }
 
@@ -139,7 +138,6 @@ pcmk__add_arg_group(GOptionContext *context, const char *name,
     g_option_group_add_entries(group, entries);
     g_option_context_add_group(context, group);
     // group is now owned by context, we don't free it here
-    // cppcheck-suppress memleak
 }
 
 static gchar *

diff --git a/lib/common/io.c b/lib/common/io.c
@@ -44,8 +44,6 @@ pcmk__build_path(const char *path_c, mode_t mode)
     int rc = pcmk_rc_ok;
     char *path = strdup(path_c);
 
-    // cppcheck seems not to understand the abort logic in CRM_CHECK
-    // cppcheck-suppress memleak
     CRM_CHECK(path != NULL, return -ENOMEM);
     for (len = strlen(path); offset < len; offset++) {
         if (path[offset] == '/') {

diff --git a/lib/common/remote.c b/lib/common/remote.c
@@ -750,8 +750,6 @@ connect_socket_retry(int sock, const struct sockaddr *addr, socklen_t addrlen,
         *timer_id = timer;
     }
 
-    // timer callback should be taking care of cb_data
-    // cppcheck-suppress memleak
     return pcmk_rc_ok;
 }
 

diff --git a/lib/common/xml_io.c b/lib/common/xml_io.c
@@ -57,8 +57,6 @@ decompress_file(const char *filename)
         goto done;
     }
 
-    // cppcheck seems not to understand the abort-logic in pcmk__realloc
-    // cppcheck-suppress memleak
     do {
         int read_len = 0;