Fix: cibverify: If no errors found, treat crm_verify result as success (bsc#1250349) #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zzhou1
requested changes
Sep 25, 2025
| When Try "crm configure verify" | ||
| Then Expected return code is "1" | ||
| Then Expected return code is "0" | ||
| Then Expected "Configuration invalid (with warnings)" in stdout |
There was a problem hiding this comment.
Caution that after pacemaker#3933 this will be changed to "Configuration may need attention"
There was a problem hiding this comment.
Then we update the test case after pacemaker upgraded
There was a problem hiding this comment.
How about this,
Suggested change
| Then Expected "Configuration invalid (with warnings)" in stdout | |
| Then Expect stdout contains snippets ["Configuration invalid (with warnings)", "Configuration may need attention"] |
There was a problem hiding this comment.
We can hold on to this PR, until pacemaker#3933 submits to Factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from #1926