[crmsh-4.6] Dev: pre-migration: Add check for obsolete SAP ASCS/ERS mount (jsc#SAPSOL-495) #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasyang2022
force-pushed
the
sapsol-495-20250924
branch
2 times, most recently
from
d5a8b2f to
3245bfb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicholasyang2022
force-pushed
the
sapsol-495-20250924
branch
4 times, most recently
from
e7d4bae to
d70ed7f
Compare
… (jsc#SAPSOL-495) This commit introduces a new check to the "migration" module to detect unsupported, cluster-controlled filesystem setups for SAP ASCS/ERS. The check identifies problematic Filesystem-based ENSA2 setups by inspecting the resource configuration. It detects configurations where: - A `SAPInstance` resource with `IS_ERS=true` is present. - A `Filesystem` resource is in the same group as the `SAPInstance`. - The `Filesystem` resource is implicitly ordered to start before the `SAPInstance`. The check relies on the implicit ordering of resources within a group and does not consider explicit `rsc_order` constraints, assuming users will rely on the default group behavior. This check should identify NetWeaver and S/4HANA ENSA2 Filesystem setup. It does not identify ENSA1 simple-mount, nor NetWeaver.
nicholasyang2022
force-pushed
the
sapsol-495-20250924
branch
from
d70ed7f to
3e40380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new check to the "migration" module to detect
unsupported, cluster-controlled filesystem setups for SAP ASCS/ERS.
The check identifies problematic Filesystem-based ENSA2 setups by
inspecting the resource configuration.
It detects configurations where:
SAPInstanceresource withIS_ERS=trueis present.Filesystemresource is in the same group as theSAPInstance.Filesystemresource is implicitly ordered to start before theSAPInstance.The check relies on the implicit ordering of resources within a group
and does not consider explicit
rsc_orderconstraints, assuming userswill rely on the default group behavior.
This check should identify NetWeaver and S/4HANA ENSA2 Filesystem setup. It does
not identify ENSA1 simple-mount, nor NetWeaver.
How to Test in Emulated Setup
ocf:suse:SAPInstancetoocf:heartbeat:Dummy.crm configure primitive fs_ers ocf:heartbeat:Filesystem params device=tmpfs directory="/mnt/dummy" fstype=tmpfscrm configure primitive ers_instance ocf:heartbeat:Dummy params InstanceName=ERS_DUMMY IS_ERS=truecrm configure group ers_group fs_ers ers_instancecrm cluster health sles16