Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: ssh_key: more robust error handling in KeyFileManager (bsc#1239084) #1706

Conversation

nicholasyang2022
Copy link
Collaborator

add set -e to the shell script so that it exits and reports on errors.

Verified

This commit was signed with the committer’s verified signature.
nicholasyang2022 Nicholas Yang
add `set -e` to the shell script so that it exits and reports on errors.
@nicholasyang2022 nicholasyang2022 force-pushed the bsc_1239084_more_robust_error_handling branch from 6575c56 to af9f40c Compare March 11, 2025 07:25
@nicholasyang2022 nicholasyang2022 changed the title Dev: ssh_key: more robust error handling in KeyFileManager Dev: ssh_key: more robust error handling in KeyFileManager (bsc#1239084) Mar 11, 2025
@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review March 11, 2025 08:12
Copy link
Collaborator

@liangxin1300 liangxin1300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Please backport to crmsh-4.6

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.73%. Comparing base (0f77021) to head (af9f40c).
Report is 5 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 53.60% <100.00%> (-0.01%) ⬇️
unit 53.08% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/ssh_key.py 74.44% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liangxin1300 liangxin1300 merged commit 9e0cd40 into ClusterLabs:master Mar 11, 2025
32 checks passed
@nicholasyang2022 nicholasyang2022 deleted the bsc_1239084_more_robust_error_handling branch March 11, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants