Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix: ui_context: Don't complete for unknown argument" #1682

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Revert "Fix: ui_context: Don't complete for unknown argument" #1682

merged 1 commit into from
Feb 8, 2025
+1 −6

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Feb 7, 2025 •
edited
Loading

This reverts commit 9c308b2.

To fix regression #1681
Since it's hard to tell if this 'unknown argument' is an id or not

@liangxin1300 liangxin1300 mentioned this pull request Feb 7, 2025
Merged
@liangxin1300 liangxin1300 marked this pull request as ready for review February 7, 2025 10:03
@liangxin1300 liangxin1300 requested a review from zzhou1 February 7, 2025 10:03
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.76%. Comparing base (7601cb1) to head (1922bd8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/ui_context.py 0.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 53.57% <0.00%> (+0.01%) ⬆️
unit 53.11% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/ui_context.py 58.23% <0.00%> (+0.87%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 merged commit c0738db into ClusterLabs:master Feb 8, 2025
31 of 32 checks passed
liangxin1300 added a commit that referenced this pull request Feb 8, 2025
@liangxin1300
[crmsh-4.6] Revert "Fix: ui_context: Don't complete for unknown argum…
0b194a6 
…ent" (#1683)

This reverts commit 3221cb9.

backport from #1682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzhou1 zzhou1 zzhou1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangxin1300 @zzhou1