Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimpleNamedDefinition #267

Open
wants to merge 1 commit into
base: 3.0
Choose a base branch
from

Conversation

WillQizza
Copy link

@WillQizza WillQizza commented Nov 28, 2024

For the other DefinitionRegistry instances other than the camera preset registry, they have classes for their definition equivalent interface. (e.g. SimpleBlockDefinition exists and implements BlockDefinition)

The problem is that for camera presets, there is no implementation of just the NamedDefinition interface. For consistency as well as to help ProxyPass support deserializing/serializing camera related packets, this class just serves as a basic implementation for NamedDefinition.

I chose to implement it here rather than in ProxyPass for consistency with the other definition classes and also it might come in handy in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant