Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the other
DefinitionRegistry
instances other than the camera preset registry, they have classes for their definition equivalent interface. (e.g.SimpleBlockDefinition
exists and implementsBlockDefinition
)The problem is that for camera presets, there is no implementation of just the
NamedDefinition
interface. For consistency as well as to help ProxyPass support deserializing/serializing camera related packets, this class just serves as a basic implementation forNamedDefinition
.I chose to implement it here rather than in
ProxyPass
for consistency with the other definition classes and also it might come in handy in the future.