Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dark Theme #394

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Dark Theme #394

wants to merge 4 commits into from

Conversation

Jatana
Copy link
Contributor

@Jatana Jatana commented Oct 26, 2018

Add dark ui mode for the fabrik.

@Ram81
Copy link
Member

Ram81 commented Oct 26, 2018

@Jatana can you also share a screenshot of the UI

@Jatana
Copy link
Contributor Author

Jatana commented Oct 26, 2018

@Ram81, here the sample - https://imgur.com/eYeyVyi

@Ram81
Copy link
Member

Ram81 commented Oct 26, 2018

@Jatana can you make toggle button similar to the following image.
toggle
And why is there a Alpha button on canvas?

@Jatana
Copy link
Contributor Author

Jatana commented Oct 26, 2018

Alpha It is changed 'Net Name'

Ram81
Ram81 reviewed Oct 26, 2018
View reviewed changes
ide/static/css/style.css
bottom: 0px;
width: 20%;
background-color: #F3F3F3;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 55e8068.

Ram81
Ram81 requested changes Oct 26, 2018
View reviewed changes
ide/static/css/style.css Outdated
.canvas{
flex: 1 1 auto;
width: 100%;
position: relative;
overflow: scroll;
// overflow: scroll;
border: 1px solid #ddd;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 5e83dc8.

ide/static/css/style.css Outdated
left: 0;
right: 0;
top: 15px;
right: 305px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix alignment of netName control it isn't placed in center of the canvas.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 5e83dc8.

@Ram81
Copy link
Member

Ram81 commented Oct 26, 2018

@Jatana good work overall. Few changes:

  • It seems you have modified style for existing layer component size. Layer height seems to be smaller to previous design. It affects our visualization algorithm so please revert the layer height.
  • ModelZoo of Fabrik doesn't match dark theme.
  • Also model name div seems to get displaced when scrolled, please revert that to original one.
    abc
    abcd

@gautamjajoo gautamjajoo mentioned this pull request Oct 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ram81 Ram81 Ram81 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jatana @Ram81