Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Upgrade changes in search functionality #4362

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

Harshit28j
Copy link

This PR follows up on the previous one (#4175) . This functionality can perform word-by-word searches using titles, tags, and domains, and can also show search results for multiple values.

Update.Changes.mp4

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.

Project coverage is 69.29%. Comparing base (96968d6) to head (186c6b1).
Report is 1110 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4362      +/-   ##
==========================================
- Coverage   72.93%   69.29%   -3.65%     
==========================================
  Files          83       20      -63     
  Lines        5368     3608    -1760     
==========================================
- Hits         3915     2500    -1415     
+ Misses       1453     1108     -345     
Files Coverage Δ
frontend/src/js/controllers/hostedChallengeCtrl.js 94.64% <84.21%> (-5.36%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 85.54% <57.89%> (-9.14%) ⬇️

... and 64 files with indirect coverage changes

Files Coverage Δ
frontend/src/js/controllers/hostedChallengeCtrl.js 94.64% <84.21%> (-5.36%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 85.54% <57.89%> (-9.14%) ⬇️

... and 64 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3c597...186c6b1. Read the comment docs.

@Harshit28j
Copy link
Author

image

Copy link
Member

@gautamjajoo gautamjajoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check the coverage report, the coverage decreased from 72% to 69%, and as you can see 11 lines are missing coverage. Add tests for that as well

@Suryansh5545
Copy link
Member

@Harshit28j The drop down menu is going over the screen
image

@Suryansh5545
Copy link
Member

When selecting "All" the challenge without domain is disappearing , this should not happen, all challenges should be shown in "All" field.
image

Copy link
Member

@gautamjajoo gautamjajoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a separate PR for tests

Copy link
Member

@Suryansh5545 Suryansh5545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the mentioned issues

customDomainFilter = $injector.get('$filter')('customDomainFilter');
}));

describe('ceil filter', function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Harshit28j What is this change for ?

});
});

describe('format_execution_time filter', function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check if time is formatted properly or not

@gautamjajoo
Copy link
Member

@Harshit28j What's the update on this PR?

@Harshit28j
Copy link
Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants