-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Upgrade changes in search functionality #4362
base: master
Are you sure you want to change the base?
Conversation
* Added Cache Busting * .
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4362 +/- ##
==========================================
- Coverage 72.93% 69.29% -3.65%
==========================================
Files 83 20 -63
Lines 5368 3608 -1760
==========================================
- Hits 3915 2500 -1415
+ Misses 1453 1108 -345
... and 64 files with indirect coverage changes
... and 64 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check the coverage report, the coverage decreased from 72% to 69%, and as you can see 11 lines are missing coverage. Add tests for that as well
@Harshit28j The drop down menu is going over the screen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make a separate PR for tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the mentioned issues
customDomainFilter = $injector.get('$filter')('customDomainFilter'); | ||
})); | ||
|
||
describe('ceil filter', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Harshit28j What is this change for ?
}); | ||
}); | ||
|
||
describe('format_execution_time filter', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To check if time is formatted properly or not
@Harshit28j What's the update on this PR? |
This PR follows up on the previous one (#4175) . This functionality can perform word-by-word searches using titles, tags, and domains, and can also show search results for multiple values.
Update.Changes.mp4