-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4897 - report css... #4899
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4899 +/- ##
=======================================
Coverage 84.80% 84.80%
=======================================
Files 319 319
Lines 19314 19314
=======================================
Hits 16379 16379
Misses 2935 2935 ☔ View full report in Codecov by Sentry. |
So the primary issue appears to be that wkhtmltopdf does not find the local static URL path. An option is to use an option |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on stage and seems to work fine, so I think this PR is good enough to merge. If the problem shows up again we can attempt the fix you suggest (the url_for thing), I think
@@ -1140,7 +1142,7 @@ <h4>Scout case analysis report</h4> - created on: <strong>{{report_created_ | |||
{{ variant_phenotypes(variant) }} | |||
</div> | |||
<div class="card-body"> | |||
<table id="panel-table" class="table table-sm table-bordered" style="background-color: transparent; margin-left:-.3rem;> | |||
<table id="panel-table" class="table table-sm table-bordered" style="background-color: transparent; margin-left:-.3rem;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
* hm, no external is no good - try direct paste style * fix old typo, same as other PR * and apply to SVs as well * changelog
This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stage
and the server iscg-vm1
.ssh <USER.NAME>@cg-vm1.scilifelab.se
sudo -iu hiseq.clinical
ssh localhost
podman ps
systemctl --user stop scout.target
systemctl --user start scout@<this_branch>
systemctl --user status scout.target
scout-stage
) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.se
us; paxa -u <user> -s hasta -r scout-stage
. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browser
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
us; scout --version
paxa
procedure, which will release the allocated resource (scout-stage
) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: