-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More LRS SV callers #4886
More LRS SV callers #4886
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4886 +/- ##
=======================================
Coverage 84.77% 84.78%
=======================================
Files 319 319
Lines 19322 19326 +4
=======================================
+ Hits 16381 16385 +4
Misses 2941 2941 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍🏻
Consider starting using constants in callers lists
Do we want to include this one in the the release? |
It's not a rush. I'll try to make a test case based on the examples from @fellen31. I'm sure the tags as such work, but it would be nice to see that the caller output actually load and show something useful in Scout when adding them. |
Quality Gate passedIssues Measures |
Taking a bit longer to get a real test case, but variants from both (without annotation) seem to be able to be uploaded to Scout. |
Ok, that is good enough for me! Annotation is reasonably proven. We can get back to nitty gritty details on specific keys for these callers later as needed. |
* Fix Clinical-Genomics#4883 - added hificnv, severus and trgt caller tags * hificnv it is * fusion callers could also be alphabetical * as well as snv callers really * Fix according to review - use subconstants --------- Co-authored-by: Chiara Rasi <[email protected]>
Fix code style issues with Black Fix 4913 - Add a small script to check panel rank (Clinical-Genomics#4914) * Fix 4913 - Add a small script to check panel rank * update output * URI * uri config option name * add a best rank * fix best rank * Panels * add owner * Save in mem instead of leaving cursors open long * header order, review suggestions More LRS SV callers (Clinical-Genomics#4886) * Fix Clinical-Genomics#4883 - added hificnv, severus and trgt caller tags * hificnv it is * fusion callers could also be alphabetical * as well as snv callers really * Fix according to review - use subconstants --------- Co-authored-by: Chiara Rasi <[email protected]> Do not show ORPHA inheritance on variant page (Clinical-Genomics#4916) * Do not display inheritance models associated to ORPHA terms on variant page * Fix tooltip as well --------- Co-authored-by: Chiara Rasi <[email protected]> Chanjo2 MANE coverage overview (Clinical-Genomics#4915) * Add mane overview also on panel page * Fix changelog after merge * Fix pseudolinks * Fix pseudolinks also on panel page --------- Co-authored-by: Chiara Rasi <[email protected]> Co-authored-by: Daniel Nilsson <[email protected]>
This PR adds a functionality or fixes a bug.
Add new potential Nallo additions Severus (https://github.com/KolmogorovLab/Severus) and HiFiCNV (https://www.pacb.com/blog/hificnv/) plus a missing tag for TRGT (https://github.com/PacificBiosciences/trgt).
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stage
and the server iscg-vm1
.ssh <USER.NAME>@cg-vm1.scilifelab.se
sudo -iu hiseq.clinical
ssh localhost
podman ps
systemctl --user stop scout.target
systemctl --user start scout@<this_branch>
systemctl --user status scout.target
scout-stage
) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.se
us; paxa -u <user> -s hasta -r scout-stage
. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browser
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
us; scout --version
paxa
procedure, which will release the allocated resource (scout-stage
) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: