Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate json submissions (germline and somatic) endpoint #152

Merged
merged 10 commits into from
Jan 30, 2025

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Jan 30, 2025

Description

How to test

  • Use the swagger endpoint to validate one germline and one somatic json submissions - retrieve examples from ClinVar

Expected test outcome

  • Files should be validated

Review

  • Tests executed by CR. GitHub actions

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.88%. Comparing base (3bf9613) to head (1547ebb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
preClinVar/main.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   95.25%   94.88%   -0.38%     
==========================================
  Files          11       11              
  Lines         506      528      +22     
==========================================
+ Hits          482      501      +19     
- Misses         24       27       +3     
Flag Coverage Δ
unittests 94.88% <91.42%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch marked this pull request as ready for review January 30, 2025 07:30
@northwestwitch
Copy link
Member Author

Validation of germline submission

image

Validation of somatic submission

image

@northwestwitch northwestwitch merged commit c64b978 into main Jan 30, 2025
8 checks passed
@northwestwitch northwestwitch deleted the validate_submission_simple branch January 30, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate only endpoint
2 participants