Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that current file conversion endpoints work only for germline submissions #146

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Jan 29, 2025

Description

Changed

How to test

  • Automatic tests

Expected test outcome

  • All tests should pass

Review

  • Tests executed by GitHub actions
  • "Merge and deploy" approved by

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch northwestwitch changed the title Soecify that current file conversion endpoints work only for germline submissions Specify that current file conversion endpoints work only for germline submissions Jan 29, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.25%. Comparing base (123ee47) to head (4d40f1e).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   95.30%   95.25%   -0.05%     
==========================================
  Files          11       11              
  Lines         490      506      +16     
==========================================
+ Hits          467      482      +15     
- Misses         23       24       +1     
Flag Coverage Δ
unittests 95.25% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch merged commit 7b2959e into main Jan 29, 2025
7 checks passed
@northwestwitch northwestwitch deleted the specify_germline_support branch January 30, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it clear that the app is only supporting germline conversions/validations at the moment
2 participants