Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerfile cmd #143

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix dockerfile cmd #143

merged 2 commits into from
Nov 21, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Nov 21, 2024

Description

Fixed

How to test

  • Run docker-compose up locally

Expected test outcome

  • Check that the container is running
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by CR
  • "Merge and deploy" approved by

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch
Copy link
Member Author

Tested locally:

image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.25%. Comparing base (123ee47) to head (fa9203f).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   95.30%   95.25%   -0.05%     
==========================================
  Files          11       11              
  Lines         490      506      +16     
==========================================
+ Hits          467      482      +15     
- Misses         23       24       +1     
Flag Coverage Δ
unittests 95.25% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@northwestwitch northwestwitch merged commit 506e5db into main Nov 21, 2024
7 checks passed
@northwestwitch
Copy link
Member Author

Deployed on prod now:

image

@northwestwitch northwestwitch deleted the fix_dockerfile_cmd branch January 23, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants