Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate on event and replace it with app lifespan #140

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Nov 21, 2024

Description

Changed

How to test

  • Launch the app locally

Review

  • Tests executed by CR
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.25%. Comparing base (123ee47) to head (3d1a7b6).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
preClinVar/main.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   95.30%   95.25%   -0.05%     
==========================================
  Files          11       11              
  Lines         490      506      +16     
==========================================
+ Hits          467      482      +15     
- Misses         23       24       +1     
Flag Coverage Δ
unittests 95.25% <80.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@northwestwitch
Copy link
Member Author

Tested locally: 🆗

image

@northwestwitch northwestwitch merged commit b06e142 into main Nov 21, 2024
7 checks passed
@northwestwitch northwestwitch deleted the deprecate_on_event branch January 23, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deprecatiob] on_event is deprecated, use lifespan event handlers instead.
2 participants